Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make api around Salt consistent #964

Merged
merged 3 commits into from
May 16, 2023
Merged

chore: make api around Salt consistent #964

merged 3 commits into from
May 16, 2023

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented May 15, 2023 •
edited
Loading

Every method that accepts Salt now accepts Into<Salt>to be consistent with the LoadConfiguration setter

@MujkicA MujkicA requested review from digorithm and iqdecay as code owners May 15, 2023 13:13
@MujkicA MujkicA requested a review from a team May 15, 2023 13:14
@MujkicA MujkicA added the tech-debt Improves code quality or safety label May 15, 2023
@MujkicA MujkicA self-assigned this May 15, 2023
@MujkicA MujkicA added enhancement New feature or request and removed tech-debt Improves code quality or safety labels May 15, 2023
Salka1988
Salka1988 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Salka1988
Salka1988 approved these changes May 16, 2023 •
edited
Loading
View reviewed changes
@MujkicA MujkicA merged commit 70e531f into master May 16, 2023
@MujkicA MujkicA deleted the mujkica/make-salt-consistent-in-api branch May 16, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal3e hal3e hal3e approved these changes

@iqdecay iqdecay iqdecay approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@MujkicA MujkicA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MujkicA @Br1ght0ne @Salka1988 @iqdecay @hal3e