Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for DbType::RocksDb #998

Merged
merged 84 commits into from
Jul 13, 2023
Merged

feat: add support for DbType::RocksDb #998

merged 84 commits into from
Jul 13, 2023

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Jun 11, 2023 •
edited
Loading

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Salka1988 Salka1988 added the enhancement New feature or request label Jun 11, 2023
@Salka1988 Salka1988 requested a review from digorithm as a code owner June 11, 2023 21:51
@Salka1988 Salka1988 self-assigned this Jun 11, 2023
@Salka1988 Salka1988 linked an issue Jun 11, 2023 that may be closed by this pull request
Start a node from an initial database state #981
Closed
Voxelot
Voxelot reviewed Jun 12, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
MujkicA
MujkicA reviewed Jun 14, 2023
View reviewed changes
packages/fuels/.DS_Store Outdated Show resolved Hide resolved
@Salka1988 Salka1988 requested a review from iqdecay July 5, 2023 10:01
digorithm
digorithm requested changes Jul 5, 2023
View reviewed changes
docs/src/connecting/rocksdb.md Outdated Show resolved Hide resolved
docs/src/connecting/rocksdb.md Outdated Show resolved Hide resolved
docs/src/connecting/short-lived.md Outdated Show resolved Hide resolved
packages/fuels-test-helpers/src/node.rs Outdated Show resolved Hide resolved
packages/fuels/tests/contracts.rs Show resolved Hide resolved
packages/fuels/tests/contracts.rs Outdated Show resolved Hide resolved
Salka1988 and others added 5 commits July 6, 2023 12:25
@Salka1988 @iqdecay
Update docs/src/connecting/rocksdb.md
cbdfe27 
Co-authored-by: iqdecay <victor@berasconsulting.com>
@Salka1988 @digorithm
Update docs/src/connecting/rocksdb.md
1b9fb76 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@Salka1988 @digorithm
Update docs/src/connecting/rocksdb.md
71be9d9 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@Salka1988 @digorithm
Update docs/src/connecting/short-lived.md
c583144 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@Salka1988 @digorithm
Update packages/fuels-test-helpers/src/node.rs
3268d20 
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@Salka1988 Salka1988 requested review from digorithm and Voxelot July 6, 2023 12:03
segfault-magnet
segfault-magnet reviewed Jul 11, 2023
View reviewed changes
docs/src/connecting/rocksdb.md Outdated Show resolved Hide resolved
packages/fuels-test-helpers/src/node.rs Outdated Show resolved Hide resolved
packages/fuels/tests/contracts.rs Outdated Show resolved Hide resolved
segfault-magnet
segfault-magnet previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small suggestion

packages/fuels-test-helpers/src/node.rs Outdated Show resolved Hide resolved
digorithm
digorithm approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @Salka1988!

@Salka1988 Salka1988 dismissed iqdecay’s stale review July 13, 2023 08:09

Outdated. Everything is updated.

@Salka1988 Salka1988 merged commit 294f91b into master Jul 13, 2023
@Salka1988 Salka1988 deleted the Salka1988/db branch July 13, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@hal3e hal3e hal3e approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm digorithm approved these changes

@Braqzen Braqzen Braqzen left review comments

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@iqdecay iqdecay Awaiting requested review from iqdecay

@Voxelot Voxelot Awaiting requested review from Voxelot

Assignees

@Salka1988 Salka1988

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start a node from an initial database state
9 participants
@Salka1988 @Voxelot @digorithm @Br1ght0ne @MujkicA @iqdecay @hal3e @segfault-magnet @Braqzen