Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate usage of Buffer in bytecode compression #2984

Closed
petertonysmith94 opened this issue Aug 20, 2024 · 1 comment · Fixed by #2985
Closed

Re-evaluate usage of Buffer in bytecode compression #2984

petertonysmith94 opened this issue Aug 20, 2024 · 1 comment · Fixed by #2985
Assignees
@petertonysmith94
Labels
bug Issue is a bug

Comments

@petertonysmith94
Copy link
Contributor

Incoming from the forum

The latest version of the TS SDK (0.94.0) uses decompressBytecode function in the factory, which requires the node builtin Buffer, which isn’t available in most Frontend Envs and causes issues especially with Vite.

This causes the following issue on a frontend application:

ReferenceError: Buffer is not defined
@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Aug 20, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 20, 2024
@arboleya
Copy link
Member

For historical context:

@petertonysmith94 petertonysmith94 mentioned this issue Aug 20, 2024
Merged
4 tasks
@danielbate danielbate mentioned this issue Aug 22, 2024
Open
@danielbate danielbate mentioned this issue Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: made bytecode compression browser compatible FuelLabs/fuels-ts
2 participants
@arboleya @petertonysmith94