-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: made bytecode compression browser compatible #2985
Conversation
This PR is published in NPM with version 0.0.0-pr-2985-20240820110320 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @petertonysmith94 , we should probably disable the Buffer
polyfill in the browser test config so that our tests catch instances where we may expect browser compatibility but we have false negatives due to node polyfills. I noted that quite a few tests failed when I did that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage Report:
Changed Files:
|
Buffer
in bytecode compression #2984Release notes
In this release, we:
Checklist