Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made bytecode compression browser compatible #2985

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 20, 2024

Release notes

In this release, we:

  • Improved browser compatibility for typegen'd bytecode compression

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Aug 20, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 20, 2024
Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-2985-20240820110320

@petertonysmith94 petertonysmith94 marked this pull request as ready for review August 20, 2024 14:23
@petertonysmith94 petertonysmith94 changed the title fix: compression buffer not defined fix: made bytecode compression browser compatible Aug 20, 2024
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) August 20, 2024 15:13
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @petertonysmith94 , we should probably disable the Buffer polyfill in the browser test config so that our tests catch instances where we may expect browser compatibility but we have false negatives due to node polyfills. I noted that quite a few tests failed when I did that.

packages/utils/src/utils/bytecode.ts Show resolved Hide resolved
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maschad I've added #3007 for us to look into reducing the number of polyfills we need.

@danielbate danielbate enabled auto-merge (squash) August 22, 2024 09:38
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.79%(+0%) 77.84%(+0.02%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 87.17%
(+0.16%)
47.36%
(+0%)
100%
(+0%)
87.17%
(+0.16%)
🔴 packages/utils/src/utils/bytecode.ts 92.85%
(+1.19%)
50%
(+0%)
100%
(+0%)
92.85%
(+1.19%)

@danielbate danielbate merged commit 9bba305 into master Aug 22, 2024
20 checks passed
@danielbate danielbate deleted the ps/fix/compression-buffer-not-defined branch August 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-evaluate usage of Buffer in bytecode compression
7 participants