feat: replace lodash with ramda #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbate
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
nedsalk
as code owners
Coverage report
Show files with reduced coverage 🔻
Test suite run success1198 tests passing in 207 suites. Report generated by 🧪jest coverage report action from 6016ea7 |
Dhaiwat10
approved these changes
Sep 8, 2023
camsjams
approved these changes
Sep 8, 2023
|
@Dhaiwat10 I can get a topic branch going if that is preferred, however I as part of this work I will also be upgrading other packages. For example, ethers v5 -> v6 as that bring ES support, which I think would be good to have on |
|
@camsjams Ramda has supported tree-shaking since |
arboleya
approved these changes
Sep 10, 2023
|
@camsjams the bundle size actually looks to be smaller with ramda so yes definitely some smart bundling happening, therefore I am going to merge this PR. Master: ESM dist/index.mjs 883.00 B
ESM dist/cli.mjs 684.00 B
ESM dist/bin.mjs 721.00 B
ESM dist/index.mjs.map 1.12 KB
ESM dist/cli.mjs.map 1.16 KB
ESM dist/bin.mjs.map 1.28 KB
ESM ⚡️ Build success in 10ms
CJS dist/bin.js 761.00 B
CJS dist/index.js 3.49 KB
CJS dist/cli.js 1.66 KB
CJS dist/bin.js.map 1.31 KB
CJS dist/cli.js.map 1.24 KB
CJS dist/index.js.map 1.32 KB
CJS ⚡️ Build success in 10ms
IIFE dist/bin.global.js 871.63 KB
IIFE dist/cli.global.js 871.58 KB
IIFE dist/index.global.js 1.94 MB
IIFE dist/cli.global.js.map 1.50 MB
IIFE dist/bin.global.js.map 1.50 MB
IIFE dist/index.global.js.map 3.48 MBw/ Ramda: ESM dist/bin.mjs 721.00 B
ESM dist/cli.mjs 684.00 B
ESM dist/index.mjs 883.00 B
ESM dist/index.mjs.map 1.12 KB
ESM dist/cli.mjs.map 1.16 KB
ESM dist/bin.mjs.map 1.28 KB
ESM ⚡️ Build success in 11ms
CJS dist/index.js 3.49 KB
CJS dist/cli.js 1.66 KB
CJS dist/bin.js 761.00 B
CJS dist/index.js.map 1.32 KB
CJS dist/bin.js.map 1.31 KB
CJS dist/cli.js.map 1.24 KB
CJS ⚡️ Build success in 11ms
IIFE dist/bin.global.js 873.39 KB
IIFE dist/cli.global.js 873.34 KB
IIFE dist/index.global.js 1.92 MB
IIFE dist/bin.global.js.map 1.49 MB
IIFE dist/cli.global.js.map 1.49 MB
IIFE dist/index.global.js.map 3.42 MB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is instigated by the efforts to support browser testing, specifically regarding Vitest. The version of lodash we use does not export for ESM. This PR looks to swap out lodash for ramda, which exports both CJS and ESM.
Relates to #284 and specifically this comment.