-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky retry test #1654
Merged
Merged
fix: flaky retry test #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: output build errors * chore: changeset
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
January 16, 2024 14:04
arboleya
previously approved these changes
Jan 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
arboleya
reviewed
Jan 16, 2024
arboleya
requested changes
Jan 17, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Torres-ssf
previously approved these changes
Jan 17, 2024
arboleya
previously approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🚀
I left a couple of optional nits, one tyop, one question, one todo.
arboleya
reviewed
Jan 17, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
arboleya
approved these changes
Jan 18, 2024
Torres-ssf
approved these changes
Jan 18, 2024
Coverage Report:
Changed Files:
|
arboleya
added a commit
that referenced
this pull request
Jan 26, 2024
* chore: updating code owners (#1496) * docs: purge hardcoded snippets on 'using typegen' page (#1403) * chore: remove method that's same as base method (#1445) * chore: implement RC workflow (#1497) * Revert "feat: add `Predicate.getTransferTxId` helper (#1467)" * chore: fix rc release string replace (#1529) * docs: Update some hyperlinks to reference the new documentation hub (#1520) * chore: improve rc release message (#1559) * feat: GraphQL subscriptions (#1374) * chore: pin `graphql-request` to `v5` (#1567) * chore: upgrade `tsx` (#1574) * feat: migrate from Jest to Vitest (#1310) * chore: fix temp test workflow (#1579) * chore: update required node engine in `create-fuels` (#1582) * chore: add node version test matrix (#1575) * chore: fix broken rc message (#1580) * chore: update nodejs to v20 (#1544) * feat: accepting addresses as `string` (#1583) * chore: properly format the PR coverage report comment (#1586) * fix: flaky test (#1590) * docs: update `deposit-and-withdraw` page (#1591) * feat: retry mechanism (#1474) * feat: replaced `semver` dependency with custom implementation (#1594) * feat: replace `elliptic` with `@noble/curves` (#1601) * chore: fix CI failing due to missing tag in test (#1614) * feat: improve ABI Coders `decode` validation (#1426) * fix: do not generate a coverage diff without coverage artifact (#1629) * chore: pinpoint vitest to 1.0.4 (#1637) * chore: remove `ethers` dependency from `utils` (#1640) * fix: `getOperation` for `Transfer Asset` (#1619) * fix: remove external font dependencies (#1642) * fix: generate RC PR comment on `pull_request` event only (#1648) * fix: fix failing `rc` comment (#1657) * chore: add missing test group (#1658) * feat: implement browser compatibility testing (#1630) * chore: fix string replace in `rc` ci (#1659) * chore: adding extra reporters (#1661) * chore: manually trigger `rc` CI (#1660) * feat: use `submitAndAwait` graphql endpoint (#1615) * fix: flaky retry test (#1654) * feat: create a wallet without a provider (#1566) * chore!: Share single chainConfig and review node-related utilities (#1602) * chore: use new temporary coverage artifact (#1676) * fix: internalizing `findBinPath` utility (#1679)
petertonysmith94
pushed a commit
to petertonysmith94/fuels-ts
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased
expectedWaitTime
tolerance to 50. This is still in the acceptable range becausebaseDuration
is 150, so anything off in the retry algorithm would be registered.