Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add CDNJS example #1724

Merged
merged 6 commits into from
Feb 7, 2024
Merged

docs: add CDNJS example #1724

merged 6 commits into from
Feb 7, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added docs Requests pertinent to documentation feat Issue is a feature labels Feb 6, 2024
@Torres-ssf Torres-ssf self-assigned this Feb 6, 2024
danielbate
danielbate previously approved these changes Feb 7, 2024
View reviewed changes
apps/docs/src/getting-started.md Show resolved Hide resolved
arboleya
arboleya reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have provided a minified version, but that can be done in another PR.

apps/docs/src/getting-started.md Outdated Show resolved Hide resolved
@Torres-ssf @arboleya
Update apps/docs/src/getting-started.md
55d246b 
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@Torres-ssf Torres-ssf requested a review from danielbate February 7, 2024 11:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Coverage Report:

Lines Branches Functions Statements
78.46%(+0%) 68.5%(+0%) 76.65%(+0%) 78.42%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 100fa93 into master Feb 7, 2024
21 checks passed
@Torres-ssf Torres-ssf deleted the st/docs/add-cdnjs-example branch February 7, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
docs Requests pertinent to documentation feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CDN Availability
3 participants
@Torres-ssf @arboleya @danielbate