Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: upgrade fuel-core to 0.23.0 #1764

Closed
wants to merge 184 commits into from
Closed

chore!: upgrade fuel-core to 0.23.0 #1764

wants to merge 184 commits into from

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Feb 15, 2024 •
edited
Loading

Current Tests Passing:
Screenshot 2024-04-02 at 16 12 11

Breaking Changes

  • Requires Forc 0.51.1
  • Setting maxFee is always required now ( The SDK estimates it by default with Provider.getTransactionCost + Account.fund )
  • gasPrice is calculated by the VM so we do not need to inform it anymore. The Policy gasPrice was replaced by tip
  • Account.fund signature has changed
  • Graphql URL now includes a versioning path: http://127.0.0.1:4000/v1/graphql
  • calculateTransactionFee now requires tip, maxGasPerTx, and gasPrice
  • calculateTransactionFee does not receive gasUsed anymore
  • removed unneeded properties returned by Provider.getTransactionCost

@Torres-ssf Torres-ssf added feat Issue is a feature mainnet labels Feb 15, 2024
@Torres-ssf Torres-ssf self-assigned this Feb 15, 2024
@Torres-ssf Torres-ssf mentioned this pull request Feb 27, 2024
Merged
@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented Mar 4, 2024 •
edited
Loading

Blocked by the next fuel-core release that will include: FuelLabs/fuel-core#1631

UPDATE:

Blocked by the next test-net release

@Torres-ssf Torres-ssf changed the title chore: upgrade fuel-core to 0.23.0 chore!: upgrade fuel-core to 0.23.0 Apr 4, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review April 4, 2024 02:31
@Torres-ssf Torres-ssf marked this pull request as draft April 4, 2024 02:32
@Torres-ssf Torres-ssf changed the base branch from aa/chore/upgrading-forc-0.51.1 to master April 4, 2024 11:28
@Torres-ssf Torres-ssf marked this pull request as ready for review April 4, 2024 12:29
@Torres-ssf Torres-ssf requested a review from maschad as a code owner April 4, 2024 12:29
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Apr 4, 2024 •
edited
Loading

✨ A PR has been created under the rc-1764 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1213

@Torres-ssf
Copy link
Contributor Author

Closing this in favor of #2021

@Torres-ssf Torres-ssf closed this Apr 8, 2024
@arboleya arboleya deleted the st/chore/update-dry-run-mutation branch April 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fuel-core to 0.24.3 Fetch latest gas price from fuel-core node Support new dry_run interface
4 participants
@Torres-ssf @fuel-service-user @arboleya @petertonysmith94