feat!: v1 encoding and encoding improvements
#1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feat/v1-encoding-improvements
Closed
danielbate
changed the title
v1 encoding and encoding improvementsv1 encoding and encoding improvements
Torres-ssf
previously approved these changes
Feb 22, 2024
Dhaiwat10
previously approved these changes
Feb 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
danielbate
dismissed stale reviews from Dhaiwat10, Torres-ssf, and nedsalk
via
6b0ea22
|
Coverage Report:
Changed Files:
|
danielbate
requested review from
Dhaiwat10,
Torres-ssf,
nedsalk and
arboleya
arboleya
approved these changes
Feb 23, 2024
Dhaiwat10
approved these changes
Feb 23, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the process set out in #1672, this PR introduces encoding support following the
v1specification. Currently this is just unit tested asv1encode has not yet been supported in contract calls.This PR also introduces multiple version support through
getEncodingStrategy. There is alot of room for improvement withingetCoderV1however this will be refactored, as discussed in #1672.This PR lays the foundations for #1739 and #1749, once those have been unblocked by the Sway encoding PRs.
Breaking Change
As we would like towards a more functional approach, and given
abi-coderis subject to a lot of change at the moment, I have moved the package to the correct naming conventions for classes and functions.