feat!: deprecate multiple encoding version support for configurable constants #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
nedsalk,
petertonysmith94 and
maschad
as code owners
danielbate
changed the title
v1 support for configurables
|
✨ A PR has been created under the |
arboleya
previously approved these changes
Apr 11, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
…om/FuelLabs/fuels-ts into db/feat/deprecate-v1-configurables
arboleya
approved these changes
Apr 11, 2024
Torres-ssf
approved these changes
Apr 11, 2024
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1672.
I had incorrectly assumed that configurable constants were included for
v1encoding. They are currently unsupported.This PR removes support at the encoding entry point for configurables, and introduces a test that includes both
v0configurable encoding andv1param encoding.Breaking change:
Configurable constants are no longer being parsed using experimental encoding when programs are built using the
--experimental-new-encoding. Therefore programs built using experimental encoding, will use different schemes for arguments and configurables. This will only impact consumers if they are instantiating coders directly.