chore: reduce length of Vitest logged errors #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
arboleya
previously approved these changes
May 6, 2024
maschad
requested changes
May 6, 2024
There was a problem hiding this comment.
I think we should probably address these warnings before merging, this was raised previously by @petertonysmith94 when the vitest suite was being updated.
|
@maschad Good catch! 🎯 |
auto-merge was automatically disabled
May 6, 2024 17:05
Pull request was converted to draft
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
|
arboleya
approved these changes
May 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitestto1.6.0To Reduce Serialized Error Payload Length #2246