-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: unify wallet transfer docs #2573
docs: unify wallet transfer docs #2573
Conversation
This is just a flaky test, I suggest giving it a rerun when you see such an error :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, great work
Converting to draft until comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvares We still need to update the wallet-transferring doc page and removed the duplicated section.
Both the Transferring Assets Between Accounts
and Transferring Assets Between Wallets
sections cover the same subject.
Since the Wallet
classes extend from the Account
class, we only need the Transferring Assets Between Accounts
section as they use very similar examples.
Checklist
tests
to prove my changesdocs