Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unify wallet transfer docs #2573

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jun 21, 2024

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94
Copy link
Contributor

Hey @msensys 👋🏼

Thanks again for another contribution!

We're trying to alleviate the CI failing now (#2574) - this will then allow us to unblock your PR's.

@arboleya arboleya added the docs Requests pertinent to documentation label Jun 21, 2024
@arboleya arboleya added this to the 0.x mainnet milestone Jun 21, 2024
@mvares
Copy link
Contributor Author

mvares commented Jun 21, 2024

Hey @msensys 👋🏼

Thanks again for another contribution!

We're trying to alleviate the CI failing now (#2574) - this will then allow us to unblock your PR's.

Thank you!

At the moment, I'm seeing what happened with CI.

@petertonysmith94
Copy link
Contributor

Thank you!

At the moment, I'm seeing what happened with CI.

This is just a flaky test, I suggest giving it a rerun when you see such an error :)

Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, great work

apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
apps/docs/.vitepress/config.ts Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
@petertonysmith94
Copy link
Contributor

Converting to draft until comments have been addressed.

@petertonysmith94 petertonysmith94 marked this pull request as draft July 2, 2024 07:03
@mvares mvares requested a review from danielbate July 2, 2024 18:34
@mvares mvares requested a review from Torres-ssf July 4, 2024 16:08
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvares We still need to update the wallet-transferring doc page and removed the duplicated section.

Both the Transferring Assets Between Accounts and Transferring Assets Between Wallets sections cover the same subject.

Since the Wallet classes extend from the Account class, we only need the Transferring Assets Between Accounts section as they use very similar examples.

@Torres-ssf Torres-ssf marked this pull request as ready for review July 5, 2024 11:53
@Torres-ssf Torres-ssf requested review from nedsalk and Torres-ssf July 5, 2024 11:53
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) July 8, 2024 09:05
@petertonysmith94 petertonysmith94 merged commit c7ba7a1 into FuelLabs:master Jul 8, 2024
19 checks passed
@mvares mvares deleted the m/docs/consolidate-wallet-transferring-docs branch July 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate Wallet Transferring Documentation
6 participants