Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: integrate launchTestNode into current test suites #2579

Merged
merged 80 commits into from
Jul 19, 2024
Merged

chore: integrate launchTestNode into current test suites #2579

merged 80 commits into from
Jul 19, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Jun 21, 2024 •
edited
Loading

Summary

This removes the getSetupContract ,generateTestWallet and seedTestWallet utilities in favour of the launchTestNode utility in the fuel-gauge test suite.

Builds on the work done in https://github.com/FuelLabs/fuels-ts/pull/2378/files to add browser compatibility for the fuel-gauge test suite.

This also refactors launchTestNode to accommodate for scripts, predicates, seeding wallets with multiple wallets and different asset types, and mocking more provider methods.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

Notes

Running

pnpm test:filter packages/fuel-gauge/src/

Should result in all tests passing.

Screenshot 2024-07-11 at 4 17 20 PM

Then running

prgrep fuel-core

should return clean as there are no processes running.

nedsalk and others added 23 commits June 18, 2024 16:15
@nedsalk
feat: add browser testing support in launchTestNode utility
a6c5d8d
@nedsalk
chore: changeset update
f3724b6
@nedsalk
add missing group to test
f642a31
@nedsalk
remove unnecessary addition
99a8aed
@nedsalk
test: add test for specific port
0abbed7
@nedsalk
fix: linting
562cbf5
@nedsalk
Merge branch 'master' into ns/feat/launch-test-node-in-browser-tests
fd4a5f2
@nedsalk
Add longer timeouts
7045dcf
@maschad
Merge branch 'master' into ns/feat/launch-test-node-in-browser-tests
49b7360
@nedsalk
apply change requests
7a1ebbf
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/launch-test…
cdd971e 
…-node-in-browser-tests
@maschad
Merge branch 'master' into ns/feat/launch-test-node-in-browser-tests
475e65e
@maschad
wip
ead34f5
@maschad
Merge branch 'master' into mc/chore/integrate-launch-test-node
10af335
@maschad
removed unnecessary methods
61b28bf
@danielbate
Merge branch 'master' into ns/feat/launch-test-node-in-browser-tests
9036e45
@petertonysmith94
Merge branch 'master' into ns/feat/launch-test-node-in-browser-tests
549b1fa
@nedsalk
add /close-server endpoint
624f24b
@nedsalk
fix: linting
b5132b4
@nedsalk
increase timeout
eb8eff8
@maschad
Merge branch 'master' into mc/chore/integrate-launch-test-node
127ad84
@maschad
Merge branch 'ns/feat/launch-test-node-in-browser-tests' into mc/chor…
69a9353 
…e/integrate-launch-test-node
@maschad
test: remove getSetupContract completely
aa44421
@github-actions github-actions bot added the chore Issue is a chore label Jun 21, 2024
@maschad maschad self-assigned this Jun 21, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 24, 2024
@maschad maschad removed the blocked label Jul 18, 2024
@nedsalk @maschad
chore: improve fuel-gauge tests (#2789)
35d2e65 
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
@maschad maschad dismissed stale reviews from petertonysmith94 and danielbate via 35d2e65 July 18, 2024 15:40
@maschad maschad requested a review from arboleya July 18, 2024 16:18
@maschad maschad mentioned this pull request Jul 18, 2024
Closed
@maschad @arboleya
test: update payabale-annotation test
ceacc86 
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
nedsalk
nedsalk approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

petertonysmith94
petertonysmith94 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

arboleya
arboleya approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@maschad maschad enabled auto-merge (squash) July 19, 2024 14:19
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.36%(-0.01%) 71.65%(+0%) 77.3%(+0%) 79.49%(-0.01%)
Changed Files:

Coverage values did not change👌.

@maschad maschad merged commit 538d8b6 into master Jul 19, 2024
20 checks passed
@maschad maschad deleted the mc/chore/integrate-launch-test-node branch July 19, 2024 14:30
@fuel-service-user fuel-service-user mentioned this pull request Jul 19, 2024
Merged
@danielbate danielbate mentioned this pull request Jul 19, 2024
Merged
4 tasks
nedsalk added a commit that referenced this pull request Jul 19, 2024
@nedsalk
Revert "chore: integrate launchTestNode into current test suites (#…
9dac477 
…2579)"

This reverts commit 538d8b6.
nedsalk added a commit that referenced this pull request Jul 25, 2024
@nedsalk
Revert "Revert "chore: integrate launchTestNode into current test s…
9106b24 
…uites (#2579)""

This reverts commit 9dac477.
@danielbate danielbate mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@maschad maschad

Labels
chore Issue is a chore
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Race Condition in E2E Tests Due to Shared Predicate UTXOs Integrate launchTestNode with fuel-gauge
6 participants
@maschad @arboleya @danielbate @petertonysmith94 @nedsalk @Torres-ssf