-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: made deployContract
a non-blocking call
#2597
Conversation
…abs/fuels-ts into st/feat/make-deploy-contract-async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, couple comments
deployContract
a non-blocking call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion - rest looks good to me!
ca21b22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚
Coverage Report:
Changed Files:
|
deployContract
method a non-blocking call #2561Release notes
In this release, we:
deployContract
method a non-blocking callSummary
This PR refactors the
deployContract
method to be non-blocking. As a result, the method no longer returns the contract instance directly. Instead, it returns an object containing thetransactionId
and awaitForResult
function. This change improves the flexibility and control over contract deployment but introduces a breaking change that requires updates to existing implementations.Breaking Changes
The
deployContract
method no longer returns the contract instance directly. Instead, it returns an object containing thetransactionId
, thecontractId
, and awaitForResult
function.Checklist
tests
to prove my changesdocs