Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include all supported connectors in the create fuels template #2691

Merged
merged 35 commits into from
Jul 10, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 3, 2024

Release notes

  • Added support for multiple new connectors in the create fuels template

Summary

This PR bumps the @fuels/connectors package to 0.8.1 which includes all the new connectors.

image

This PR also fixes the 'slowness' associated with the 'Connect Wallet' button.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Jul 3, 2024
@Dhaiwat10 Dhaiwat10 added this to the 0.x mainnet milestone Jul 3, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Jul 3, 2024
Torres-ssf
Torres-ssf previously approved these changes Jul 3, 2024
arboleya
arboleya previously approved these changes Jul 3, 2024
templates/nextjs/package.json Show resolved Hide resolved
danielbate
danielbate previously approved these changes Jul 4, 2024
maschad
maschad previously approved these changes Jul 4, 2024
@Dhaiwat10
Copy link
Member Author

Marking this as a draft as it seems like there is some additional configuration that needs to be done in order for these new connectors to work on localhost and testnet

@Dhaiwat10 Dhaiwat10 marked this pull request as draft July 5, 2024 06:21
@Dhaiwat10 Dhaiwat10 dismissed stale reviews from Torres-ssf, maschad, danielbate, and arboleya via 23ffcaa July 8, 2024 06:28
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR is published in NPM with version 0.0.0-pr-2691-20240708080607

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just need to upgrade the fuel-core versions

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@Dhaiwat10 Dhaiwat10 requested a review from danielbate July 10, 2024 11:39
danielbate
danielbate previously approved these changes Jul 10, 2024
@petertonysmith94 petertonysmith94 dismissed stale reviews from danielbate and themself via 8c986a0 July 10, 2024 15:30
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.45%(-0.18%) 71.67%(+0.06%) 77.07%(-0.23%) 79.52%(-0.19%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/src/app/layout.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/app/page.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/app/faucet/page.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/app/predicate/page.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/app/script/page.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)

@Dhaiwat10 Dhaiwat10 merged commit e9b70ee into master Jul 10, 2024
19 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/bump-fuel-connectors branch July 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include all supported connectors in the create fuels template create fuels preceived slowness
6 participants