Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add infra to support multiple create fuels templates #2851

Merged
merged 23 commits into from
Aug 7, 2024
Merged

chore: add infra to support multiple create fuels templates #2851

merged 23 commits into from
Aug 7, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 29, 2024 •
edited
Loading

Summary

This PR adds a new flag to the create fuels CLI which will let users pass in a template name of their choice like so:

npm create fuels  -- --template nextjs

Do note that this PR does not add any new templates, but rather the infrastructure to support multiple of them in the future.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Jul 29, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Jul 29, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review July 29, 2024 12:56
petertonysmith94
petertonysmith94 reviewed Jul 30, 2024
View reviewed changes
packages/create-fuels/src/cli.ts Outdated Show resolved Hide resolved
packages/create-fuels/src/cli.ts Outdated Show resolved Hide resolved
packages/create-fuels/src/cli.ts Show resolved Hide resolved
packages/create-fuels/src/lib/setupProgram.ts Outdated Show resolved Hide resolved
@Dhaiwat10 Dhaiwat10 marked this pull request as draft July 30, 2024 13:28
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) August 6, 2024 12:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Coverage Report:

Lines Branches Functions Statements
79.59%(+0.03%) 71.9%(+0.03%) 77.58%(+0.02%) 79.73%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 87.01%
(+1.51%)		 47.36%
(+9.86%)		 100%
(+0%)		 87.01%
(+1.51%)
✅ ✨ packages/create-fuels/src/lib/doesTemplateExist.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)

@Dhaiwat10 Dhaiwat10 merged commit 4e82ad4 into master Aug 7, 2024
20 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/multi-templates-infra branch August 7, 2024 10:45
@fuel-service-user fuel-service-user mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple templates in create fuels
7 participants
@Dhaiwat10 @arboleya @danielbate @maschad @petertonysmith94 @nedsalk @Torres-ssf