Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing reasons to PANIC_REASONS constant #2890

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 6, 2024

Summary

This PR adds missing panic reasons to the constant PANIC_REASONS. A test suite has been implemented to verify the presence of panic reasons within the constant, using the PanicReason enum from fuels/vm-asm as a reference. The panic reasons are not directly extracted and exported from the fuels/vm-asm because it requires initialization first.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

arboleya
arboleya previously approved these changes Aug 6, 2024
danielbate
danielbate previously approved these changes Aug 6, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙🏼

@Torres-ssf Torres-ssf enabled auto-merge (squash) August 6, 2024 12:37
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Coverage Report:

Lines Branches Functions Statements
79.51%(+0%) 71.75%(+0%) 77.49%(+0%) 79.65%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 1e93dac into master Aug 6, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/add-missing-panic-reasons-to-constant branch August 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants