-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing reasons to PANIC_REASONS
constant
#2890
Merged
Torres-ssf
merged 8 commits into
master
from
st/chore/add-missing-panic-reasons-to-constant
Aug 6, 2024
Merged
chore: add missing reasons to PANIC_REASONS
constant
#2890
Torres-ssf
merged 8 commits into
master
from
st/chore/add-missing-panic-reasons-to-constant
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
August 6, 2024 12:10
arboleya
previously approved these changes
Aug 6, 2024
danielbate
previously approved these changes
Aug 6, 2024
petertonysmith94
previously approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧙🏼
…ub.com:FuelLabs/fuels-ts into st/chore/add-missing-panic-reasons-to-constant
Torres-ssf
dismissed stale reviews from petertonysmith94, danielbate, and arboleya
via
August 6, 2024 12:53
a4e004f
petertonysmith94
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛵
Coverage Report:
Changed Files:Coverage values did not change👌. |
danielbate
approved these changes
Aug 6, 2024
nedsalk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing panic reasons to the constant PANIC_REASONS. A test suite has been implemented to verify the presence of panic reasons within the constant, using the
PanicReason
enum fromfuels/vm-asm
as a reference. The panic reasons are not directly extracted and exported from thefuels/vm-asm
because it requires initialization first.Checklist
tests
to prove my changesdocs