-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transaction revert error #2896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the `statusChange` subscription
petertonysmith94
changed the title
fix: transaction
fix: transaction revert error
Aug 8, 2024
waitForStatusChange
expects the status received fr…
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
maschad
as code owners
August 8, 2024 08:47
Torres-ssf
previously approved these changes
Aug 8, 2024
danielbate
previously approved these changes
Aug 9, 2024
petertonysmith94
commented
Aug 9, 2024
arboleya
reviewed
Aug 9, 2024
packages/account/src/providers/transaction-response/transaction-response.ts
Outdated
Show resolved
Hide resolved
petertonysmith94
dismissed stale reviews from danielbate and Torres-ssf
via
August 9, 2024 14:57
ce9f592
nedsalk
previously approved these changes
Aug 9, 2024
nedsalk
approved these changes
Aug 9, 2024
arboleya
approved these changes
Aug 9, 2024
Torres-ssf
approved these changes
Aug 9, 2024
Coverage Report:
Changed Files:
|
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
statusChange
subscription. Once a change of status occurs, we perform agetTransactionWithReceipts
query.statusChange
subscription was posting aSuccessStatus
, but the sub-sequential call to thegetTransactionWithReceipts
query returned aSubmittedStatus
, which the SDK interprets as an erroneous condition.getTransactionWithReceipts
, to ensure that the response aligns with the subscription result.Checklist
tests
to prove my changesdocs