Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use internal random bytes function to avoid browser ESM file #310

Merged
merged 7 commits into from
Jun 3, 2022
Merged

fix: Use internal random bytes function to avoid browser ESM file #310

merged 7 commits into from
Jun 3, 2022

Conversation

camsjams
Copy link
Contributor

Fixes #309

@camsjams camsjams self-assigned this May 31, 2022
luizstacio
luizstacio requested changes May 31, 2022
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should export Keystore on fuels package. To be able to use randomBytes from fuels

@camsjams
Copy link
Contributor Author

I think we should export Keystore on fuels package. To be able to use randomBytes from fuels

Totally agree! This package was still private on npm until today, so I can also export it from fuels now too 👍

@camsjams
Copy link
Contributor Author

@luizstacio Ok I've updated to export randomBytes at main fuels package level, and fixed keystore type docs 🎉

luizstacio
luizstacio approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsjams camsjams merged commit 1a1fb63 into master Jun 3, 2022
@camsjams camsjams deleted the feature/issue-309 branch June 3, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio luizstacio approved these changes

@AlicanC AlicanC Awaiting requested review from AlicanC

@pedronauck pedronauck Awaiting requested review from pedronauck

Assignees

@camsjams camsjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix WARNING: Missing strong random number source
2 participants
@camsjams @luizstacio