-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error handling in Provider
for when a node is offline
#3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
helciofranco
previously approved these changes
Sep 5, 2024
Provider
for when a node is offline
arboleya
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @arthurgeron! ❤️
I applied some touchups to the PR description.
c356964
to
e81ef8c
Compare
arboleya
previously approved these changes
Sep 5, 2024
Torres-ssf
previously approved these changes
Sep 5, 2024
e81ef8c
to
8d60c53
Compare
chore: update changeset
8d60c53
to
efd6231
Compare
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Sep 5, 2024
Torres-ssf
approved these changes
Sep 6, 2024
helciofranco
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Provider
for when a node is offlineSummary
If a node is offline, the Provider middleware throws an exception when it tries to inject the auth headers into an
undefined
request object, so we check if therequest
object is valid before injecting auth headers.Checklist