Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct bn formatting bug with 0 units #3300

Merged
merged 12 commits into from
Oct 10, 2024
Merged

fix: correct bn formatting bug with 0 units #3300

merged 12 commits into from
Oct 10, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 9, 2024 •
edited
Loading

Release notes

In this release, we:

  • fixed an issue where formatting with 0 in the bn class returned an incorrect value

Summary

Fixed a formatting issue in the bn library which caused big numbers formatted with unit, minPrecision and/or precision set to 0 to be incorrectly formatted.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@maschad maschad self-assigned this Oct 9, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:43pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:43pm

@github-actions github-actions bot added the bug Issue is a bug label Oct 9, 2024
@maschad maschad requested a review from LuizAsFight October 9, 2024 22:04
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3300 will not alter performance

Comparing mc/fix/bn-precision-fix (ae2f55a) with master (9c70eba)

Summary

✅ 18 untouched benchmarks

@petertonysmith94 petertonysmith94 mentioned this pull request Oct 10, 2024
Closed
@danielbate danielbate enabled auto-merge (squash) October 10, 2024 15:34
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.12%(-0.12%) 70.19%(-0.11%) 75.13%(-0.05%) 76.25%(-0.11%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/math/src/bn.ts 88.23%
(-0.14%)		 87.5%
(+1.79%)		 80%
(+0%)		 88.23%
(-0.14%)
🔴 packages/math/src/decimal.ts 0%
(-100%)		 0%
(-50%)		 0%
(-100%)		 0%
(-100%)

@danielbate danielbate merged commit b733e81 into master Oct 10, 2024
24 checks passed
@danielbate danielbate deleted the mc/fix/bn-precision-fix branch October 10, 2024 15:56
@fuel-service-user fuel-service-user mentioned this pull request Oct 10, 2024
Merged
@danielbate danielbate mentioned this pull request Oct 11, 2024
Closed
@Dhaiwat10 Dhaiwat10 mentioned this pull request Oct 13, 2024
Merged
4 tasks
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
@maschad @petertonysmith94
@danielbate @Dhaiwat10
fix: correct bn formatting bug with 0 units (#3300)
9f4cb87 
* wip

* fix: return correcly formatted bn units

* docs: add changeset

* linting fixes

* fix: ensure signficant figures are returned even if they exceed the precision

* fix: adhere to precision if the whole number is greater than zero

* chore: update test doc

---------

Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Co-authored-by: Daniel Bate <djbate23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@maschad maschad

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bn library bugs when you're using units / precision zero
6 participants
@maschad @arboleya @danielbate @petertonysmith94 @nedsalk @Dhaiwat10