Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parseUnits bug with 0 units #3320

Merged
merged 3 commits into from
Oct 13, 2024

Merge branch 'master' into dp/fix-parse-units

ee759d7
Select commit
Loading
Failed to load commit list.
Merged

fix: parseUnits bug with 0 units #3320

Merge branch 'master' into dp/fix-parse-units
ee759d7
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Oct 13, 2024 in 0s

Performance Gate Passed

Summary

⚡ 3 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark master dp/fix-parse-units Change
should successfully get transaction cost estimate for a batch transfer (x10 times) 26.8 ms 24.3 ms +10.1%
should successfully get transaction cost estimate for a single contract call (x10 times) 27.7 ms 25 ms +10.74%
should successfully get transaction cost estimate for a single transfer (x10 times) 21.2 ms 18.1 ms +17.21%