Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proxy contract versions not being updated correctly #3339

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: proxy contract versions not being updated correctly #3339

merged 4 commits into from
Oct 21, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Oct 16, 2024 •
edited by fuel-service-user
Loading

Summary

The prebuild script wasn't building the versions package so fuels-typegen would pick up the old version of fuels, not the one that'll be released with the release PR.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the bug Issue is a bug label Oct 16, 2024
@nedsalk nedsalk self-assigned this Oct 16, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:49pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:49pm

@nedsalk nedsalk marked this pull request as ready for review October 16, 2024 07:32
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3339 will not alter performance

Comparing ns/fix/release-pr-proxy-versions (b140825) with master (3a56354)

Summary

✅ 18 untouched benchmarks

danielbate
danielbate previously approved these changes Oct 16, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Oct 16, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Oct 16, 2024
View reviewed changes
scripts/changeset/changeset-version-with-docs.ts Outdated Show resolved Hide resolved
@nedsalk nedsalk dismissed stale reviews from arboleya and Torres-ssf via 3fe83e3 October 17, 2024 08:19
@nedsalk @arboleya
Update scripts/changeset/changeset-version-with-docs.ts
3fe83e3 
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@Torres-ssf Torres-ssf enabled auto-merge (squash) October 21, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
75.98%(+0%) 70.07%(+0%) 75.09%(+0%) 76.11%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 2d21767 into master Oct 21, 2024
30 checks passed
@Torres-ssf Torres-ssf deleted the ns/fix/release-pr-proxy-versions branch October 21, 2024 15:04
@nedsalk nedsalk mentioned this pull request Nov 12, 2024
Merged
4 tasks
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
@nedsalk @Dhaiwat10
fix: proxy contract versions not being updated correctly (#3339)
6aef43d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@maschad maschad Awaiting requested review from maschad

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release PR doesn't update proxy contract versions correctly
6 participants
@nedsalk @arboleya @danielbate @petertonysmith94 @Torres-ssf @Dhaiwat10