Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing obsolete Provider.create method #3556

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Jan 7, 2025

Summary

Quick follow-up after:

Ultimately, the breaking changes were inevitable, so there's no point in keeping a deprecated method.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya added the chore Issue is a chore label Jan 7, 2025
@arboleya arboleya self-assigned this Jan 7, 2025
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 10:45am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 10:45am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 10:45am

@arboleya arboleya enabled auto-merge (squash) January 7, 2025 10:33
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage Report:

Lines Branches Functions Statements
76.95%(+0.01%) 70.41%(+0.06%) 75.01%(+0.04%) 76.95%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.7%
(+0.15%)
56.85%
(+0.29%)
70.96%
(+0.75%)
68.43%
(+0.15%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
78.08%
(+1.37%)
84%
(+0%)
88.81%
(+0%)

@arboleya arboleya merged commit 75fae34 into master Jan 7, 2025
26 checks passed
@arboleya arboleya deleted the aa/chore/removing-provider-obsolete-method branch January 7, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants