Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Option codegen and types #522

Merged
merged 9 commits into from
Sep 26, 2022
Merged

feat: improve Option codegen and types #522

merged 9 commits into from
Sep 26, 2022

Conversation

camsjams
Copy link
Contributor

Fixes #519

@camsjams camsjams requested a review from a team September 26, 2022 05:49
@camsjams camsjams self-assigned this Sep 26, 2022
Cameron Manavian added 2 commits September 25, 2022 23:00
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
89.52% (-0.62% 🔻)
3330/3720
🟡 Branches
69.92% (-0.82% 🔻)
623/891
🟢 Functions
86.32% (-0.98% 🔻)
669/775
🟢 Lines
89.47% (-0.5% 🔻)
3186/3561
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / utils.ts
36.84% 16.67% 20% 36.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / parseSvmTypes.ts
81.36% (-2.28% 🔻)
52.17% (+2.17% 🔼)
91.67% (-8.33% 🔻)
86.79% (-1.21% 🔻)
🟡
... / types.ts
60.81% (-0.06% 🔻)
64.29% (-1.17% 🔻)
66.67%
61.11% (-0.08% 🔻)

Test suite run success

504 tests passing in 45 suites.

Report generated by 🧪jest coverage report action from 7e743db

Copy link
Contributor

@matt-user matt-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luizstacio luizstacio enabled auto-merge (squash) September 26, 2022 14:15
@luizstacio luizstacio merged commit 039f930 into master Sep 26, 2022
@luizstacio luizstacio deleted the cm/issue-519 branch September 26, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuelchain does not generate the correct type for OptionOutput<>
4 participants