Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update default config values for bn.format #624

Merged
merged 5 commits into from
Dec 3, 2022
Merged

chore: update default config values for bn.format #624

merged 5 commits into from
Dec 3, 2022

Conversation

Dhaiwat10
Copy link
Contributor

Summary

This PR updates the default config values for the bn.format function as requested in #595.

// constants.ts
DEFAULT_PRECISION = 9 // previously 3
DEFAULT_MIN_PRECISION = 3 // previously 1

Closes #595

@Dhaiwat10
chore: change default config values for bn.format
2dc8110 
BREAKING CHANGE: The default config values for the `bn.format` helper functions have been
changed.

Closes: #595
@Dhaiwat10
chore: add changeset
f6c3edb
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
90.64% (+0.37% 🔼)
 3709/4092
🟡 Branches
73.08% (+0.91% 🔼)
 722/988
🟢 Functions
87.5% (+0.71% 🔼)
 735/840
🟢 Lines
90.67% (+0.38% 🔼)
 3555/3921

Test suite run success

565 tests passing in 50 suites.

Report generated by 🧪jest coverage report action from a9f2815

@Dhaiwat10
Copy link
Contributor Author

Wondering if a patch bump is enough since this PR involves a breaking change? (or does it? 🤔)

@arboleya
Copy link
Member

Perhaps it's not a breaking change per se, but it could break something that's using it.

I'd suggest a minor bump.

arboleya
arboleya previously approved these changes Nov 28, 2022
View reviewed changes
luizstacio
luizstacio previously approved these changes Nov 28, 2022
View reviewed changes
LuizAsFight
LuizAsFight previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhaiwat10 Dhaiwat10 dismissed stale reviews from LuizAsFight, luizstacio, and arboleya via ca92908 November 28, 2022 17:52
@camsjams camsjams enabled auto-merge (squash) December 3, 2022 08:22
@camsjams camsjams merged commit 8888e79 into master Dec 3, 2022
@camsjams camsjams deleted the dp/issue-595 branch December 3, 2022 08:30
@github-actions github-actions bot mentioned this pull request Dec 3, 2022
Merged
@LuizAsFight LuizAsFight mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@camsjams camsjams camsjams approved these changes

@luizstacio luizstacio luizstacio left review comments

@LuizAsFight LuizAsFight LuizAsFight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default values for bn.format
5 participants
@Dhaiwat10 @arboleya @camsjams @luizstacio @LuizAsFight