feat: move predicate to work as a wallet #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success713 tests passing in 98 suites. Report generated by 🧪jest coverage report action from c6d7c9c |
luizstacio
requested review from
camsjams,
arboleya,
LuizAsFight,
Dhaiwat10 and
digorithm
camsjams
suggested changes
Feb 17, 2023
camsjams
previously approved these changes
Feb 17, 2023
LuizAsFight
requested changes
Feb 20, 2023
LuizAsFight
previously approved these changes
Feb 20, 2023
arboleya
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Great job! 🚀
I've just left a single comment about type overloading (again). All other things I'd request have been requested from others reviewers and implemented already.
The only noteworthy exception is that we don't need to add a new package for this code split. We can DRY stuff by keeping the account.ts and account.test.ts inside the wallet package, removing many boilerplate files that don't need to exist.
LuizAsFight
previously approved these changes
Feb 21, 2023
arboleya
requested changes
Feb 21, 2023
There was a problem hiding this comment.
@luizstacio Can you please move the account.ts and account.test.ts files inside the wallet package instead of creating a new package for holding only these two files?
Let's try to DRY things, reducing the amount of boilerplate code.
arboleya
previously approved these changes
Feb 21, 2023
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
arboleya
approved these changes
Feb 21, 2023
LuizAsFight
approved these changes
Feb 21, 2023
Torres-ssf
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Predicate to be used as a Wallet, enabling predicates to be passed to contract instances, do transfers, and pay for transactions.
On this PR;
BaseWalletLockedtoAccount.Predicateand add the same API ofAccountby extending it.close: #788