Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace workflows deprecated methods #929

Merged
merged 1 commit into from
May 8, 2023
Merged

feat: Replace workflows deprecated methods #929

merged 1 commit into from
May 8, 2023

Conversation

tibi77
Copy link
Contributor

@tibi77 tibi77 commented Apr 25, 2023

Should fix #928

arboleya
arboleya requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here don't seem to follow the docs mentioned in the related issue:

@tibi77 tibi77 force-pushed the tb/chore-remove-deprecated-method branch from 81c97a2 to 7474466 Compare May 1, 2023 15:44
@tibi77 tibi77 requested a review from arboleya May 1, 2023 15:45
@tibi77
Copy link
Contributor Author

tibi77 commented May 1, 2023

@arboleya -> should be good now

@arboleya arboleya requested a review from a team May 2, 2023 12:02
@tibi77 tibi77 changed the title Replace workflows deprecated methods feat: Replace workflows deprecated methods May 2, 2023
Dhaiwat10
Dhaiwat10 approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tibi77, LGTM!

@tibi77
Copy link
Contributor Author

tibi77 commented May 5, 2023

@arboleya could you have another look?

@arboleya arboleya requested a review from a team May 5, 2023 14:13
@tibi77 tibi77 force-pushed the tb/chore-remove-deprecated-method branch from 4d46b22 to 1a6165b Compare May 6, 2023 02:53
@tibi77 tibi77 force-pushed the tb/chore-remove-deprecated-method branch from 1a6165b to 6dcdf07 Compare May 7, 2023 20:50
@tibi77
Copy link
Contributor Author

tibi77 commented May 7, 2023

I don t have access to merge this, could someone do this :)

@Torres-ssf Torres-ssf merged commit ddca7c8 into FuelLabs:master May 8, 2023
@arboleya arboleya mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@arboleya arboleya arboleya approved these changes

Assignees

@tibi77 tibi77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace workflows deprecated methods
4 participants
@tibi77 @arboleya @Torres-ssf @Dhaiwat10