-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional UTXO caching #930
Conversation
Coverage report
Show new covered files 🐣
Test suite run success874 tests passing in 136 suites. Report generated by 🧪jest coverage report action from 64100d0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey good job 👍
About to go a little bikeshedding here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great.
Just this comment:
IMO, the class should have a method getAllEntries()
or similar, that returns everything. Consumers could then choose to filter the entries however they like.
@arboleya this has been revised to be more clear about the methods and their return data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great apart from some formatting changes that crept in to provider.test.ts
🫡
closes: #865
This option is disabled by default (a point of discussion⚠️ )
This can be enabled like so:
Non-zero number