-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configurable contants for predicates #998
feat: support configurable contants for predicates #998
Conversation
Torres-ssf
commented
May 11, 2023
- Close: Configurable Constants For Predicates #997
Coverage report
Test suite run success896 tests passing in 140 suites. Report generated by 🧪jest coverage report action from 5698280 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🚀
The docs say that configurables
can be a "flexible mechanism for customizing Predicates behavior", but in my understanding, we're deriving (factoring) new Predicates instead. No?
In other words, if the use of configurables
recomputes the Predicate's bytes
and address
and results in a new Predicate entirely, the first sentence might give a wrong idea.
I wonder if my assumptions are all correct. If they are, these details must be better explained in the docs.
Since much of the configurables
magic is done internally, it can be challenging for users to grasp it unless it is explicitly mentioned.
apps/docs-snippets/src/guide/predicates/predicates-with-configurable.test.ts
Outdated
Show resolved
Hide resolved
@arboleya Yeah, I agree with you. I've added a more detailed explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tyop.
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Great work here. This will be very useful for all our predicate infrastructure. |