feat: create addNetwork request method on sdk #793

eswarasai · 2023-06-21T16:58:32Z

FRO-84
Fixes: #389

Description

Implemented addNetwork() method on Fuel SDK enabling developers to add network

TODO

Add storybook for AddNetworkRequest screen

github-actions · 2023-06-22T17:54:06Z

Coverage report for `./packages/app`

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	69.4%	3693/5321
🔴	Branches	47.14%	685/1453
🔴	Functions	53.94%	800/1483
🟡	Lines	70%	3556/5080

Test suite run success

339 tests passing in 74 suites.

Report generated by 🧪jest coverage report action from b9b0b30

LuizAsFight

nice work @eswarasai , few changes but overall looking pretty solid

packages/app/src/systems/DApp/machines/addNetworkRequestMachine.tsx

packages/docs/docs/dev/networks.mdx

luizstacio

When adding a URL that already exists the SDK should throw an error before opening the UI for the user. This validation needs to be on the same level of url format.

luizstacio · 2023-07-03T17:41:44Z

packages/app/src/systems/DApp/hooks/useAddNetworkRequest.tsx

+  /* store.useUpdateMachineConfig(Services.txRequest, {
+    actions: {
+      notifyRefreshNetworks () {
+        store.refreshNetworks();
+      },
+      notifyUpdateAccounts () {
+        store.updateAccounts();
+      },
+    },
+  }); */


You can remove this code?

luizstacio · 2023-07-03T17:43:13Z

packages/app/src/systems/Network/hooks/useNetworks.ts

+  useEffect(() => {
+    store.refreshNetworks();
+  }, []);


Why we need this refresh here?

Just to ensure that the networks in the store are being refreshed and up-to-date with the data stored in the IndexedDB
cc: @LuizAsFight

@LuizAsFight do we have some cache on the network list? If not I don't see why it would be needed.

@luizstacio
this is just to make sure that when network list opens, network list will be correct

as network machine is global, if some other machine forget to call notifyRefreshNetworks after change networks, the list will be incorrect.

I don't think we should cover forgetting notifyRefreshNetworks. This needs to be called for an application to run correctly. And as we don't have caches every time the application is open, it should refresh.

I don't see what's the problem, a refetch when opening a list is a pretty common behavior

packages/app/src/systems/Network/components/NetworkForm/NetworkForm.tsx

packages/app/src/systems/CRX/background/services/BackgroundService.ts

packages/app/src/systems/Network/services/network.ts

packages/app/src/systems/DApp/machines/addNetworkRequestMachine.tsx

LuizAsFight · 2023-07-04T16:22:30Z

packages/docs/docs/dev/reference.mdx

@@ -45,6 +45,13 @@ Return the current account being used in the wallet application.
  testCase="currentAccount"
 />

+### Add Network


should also add List Networks, and Current Network

LuizAsFight

lgtm 🏖️

packages/docs/docs/dev/networks.mdx

@mpoplavkov

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuel-wallet/sdk@0.11.0 ### Minor Changes - [#806](#806) [`e94d273`](e94d273) Thanks [@mpoplavkov](https://github.com/mpoplavkov)! - fix: default connector Fuel Wallet - [#793](#793) [`7e7300f`](7e7300f) Thanks [@eswarasai](https://github.com/eswarasai)! - Implemented `addNetwork()` method on Fuel SDK enabling developers to add network - [#764](#764) [`144d722`](144d722) Thanks [@eswarasai](https://github.com/eswarasai)! - Enabled FuelWallet SDK to be use directly without the need to wait for the injected script - [#759](#759) [`f79897d`](f79897d) Thanks [@tomiiide](https://github.com/tomiiide)! - Handle all errors in the wallet ### Patch Changes - [#686](#686) [`98c8184`](98c8184) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: add sdk.addAbi to add custom ABIs for contracts - [#814](#814) [`1cdb147`](1cdb147) Thanks [@luizstacio](https://github.com/luizstacio)! - Fix SDK to enable been used in standalone mode by adding uuid on requests ## @fuel-wallet/types@0.11.0 ### Minor Changes - [#759](#759) [`f79897d`](f79897d) Thanks [@tomiiide](https://github.com/tomiiide)! - Handle all errors in the wallet ### Patch Changes - [#686](#686) [`98c8184`](98c8184) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: add support to show called methods/params passed to contract calls inside Transaction Screen ## fuels-wallet@0.11.0 ### Minor Changes - [#801](#801) [`992d5e7`](992d5e7) Thanks [@eswarasai](https://github.com/eswarasai)! - Added support for user to connect multiple accounts, even if current account is connected - [#793](#793) [`7e7300f`](7e7300f) Thanks [@eswarasai](https://github.com/eswarasai)! - Implemented `addNetwork()` method on Fuel SDK enabling developers to add network ### Patch Changes - [#813](#813) [`3910e87`](3910e87) Thanks [@luizstacio](https://github.com/luizstacio)! - Fix validation on Asset Screen to allow empty image url field - [#802](#802) [`3b42a3d`](3b42a3d) Thanks [@eswarasai](https://github.com/eswarasai)! - Fixed the broken copy transaction link in send transaction screen - [#794](#794) [`3122ccd`](3122ccd) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - Don't allow connecting hidden accounts - [#792](#792) [`5b6b062`](5b6b062) Thanks [@luizstacio](https://github.com/luizstacio)! - Change dependencies from @fuel-ts/\* to fuels - [#686](#686) [`98c8184`](98c8184) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: add support to show called methods/params passed to contract calls inside Transaction Screen - Updated dependencies \[[`98c8184`](98c8184), [`e94d273`](e94d273), [`7e7300f`](7e7300f), [`1cdb147`](1cdb147), [`144d722`](144d722), [`f79897d`](f79897d), [`98c8184`](98c8184)]: - @fuel-wallet/sdk@0.11.0 - @fuel-wallet/types@0.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

eswarasai self-assigned this Jun 21, 2023

vercel bot deployed to Preview June 21, 2023 16:59 View deployment

eswarasai force-pushed the feat/add-network branch from b56cfd4 to b68d44e Compare June 22, 2023 17:43

eswarasai marked this pull request as ready for review June 22, 2023 17:44

eswarasai requested review from luizstacio, LuizAsFight, matt-user, pedronauck, tomiiide and sarahschwartz June 22, 2023 17:44

vercel bot deployed to Preview June 22, 2023 17:48 View deployment

This comment was marked as resolved.

Sign in to view

LuizAsFight requested changes Jun 23, 2023

View reviewed changes

packages/app/src/systems/DApp/machines/addNetworkRequestMachine.tsx Outdated Show resolved Hide resolved

packages/docs/docs/dev/networks.mdx Show resolved Hide resolved

vercel bot deployed to Preview June 28, 2023 10:29 View deployment

vercel bot deployed to Preview June 29, 2023 14:29 View deployment

vercel bot deployed to Preview June 30, 2023 06:27 View deployment

eswarasai requested a review from LuizAsFight June 30, 2023 06:45

eswarasai force-pushed the feat/add-network branch from f4f6911 to 3a52bd8 Compare July 3, 2023 12:52

vercel bot deployed to Preview July 3, 2023 12:57 View deployment

luizstacio requested changes Jul 3, 2023

View reviewed changes

vercel bot deployed to Preview July 4, 2023 13:20 View deployment

LuizAsFight requested changes Jul 4, 2023

View reviewed changes

vercel bot deployed to Preview July 5, 2023 13:54 View deployment

eswarasai added 5 commits July 5, 2023 21:56

feat: add network request screen

Verified

This commit was signed with the committer’s verified signature.

snyk-bot Snyk bot

GPG key ID: 78AC5AE55A47A65B

Verified
Learn about vigilant mode

cfa1aa5

chore: add AddNetworkRequest storybook

2f4eacf

chore: add NetworkReviewCard component

950bcab

chore: add network request test

1266a63

chore: add addNetwork in reference docs

9c6039a

eswarasai added 2 commits July 5, 2023 21:56

fix: review comments

f2a48ac

fix: review comments

db64e19

eswarasai force-pushed the feat/add-network branch from 006631b to db64e19 Compare July 5, 2023 17:23

vercel bot deployed to Preview July 5, 2023 17:27 View deployment

eswarasai requested review from luizstacio and LuizAsFight July 5, 2023 17:39

LuizAsFight previously approved these changes Jul 6, 2023

View reviewed changes

Merge branch 'master' into feat/add-network

0c4df19

vercel bot deployed to Preview July 6, 2023 05:38 View deployment

luizstacio requested changes Jul 6, 2023

View reviewed changes

packages/docs/docs/dev/networks.mdx Outdated Show resolved Hide resolved

eswarasai dismissed LuizAsFight’s stale review via 9fabd41 July 6, 2023 10:19

vercel bot deployed to Preview July 6, 2023 10:22 View deployment

fix: addNetwork docs

b9b0b30

eswarasai force-pushed the feat/add-network branch from 9fabd41 to b9b0b30 Compare July 6, 2023 14:04

vercel bot deployed to Preview July 6, 2023 14:10 View deployment

luizstacio approved these changes Jul 6, 2023

View reviewed changes

eswarasai requested a review from LuizAsFight July 6, 2023 19:17

LuizAsFight approved these changes Jul 7, 2023

View reviewed changes

eswarasai merged commit 7e7300f into master Jul 7, 2023

eswarasai deleted the feat/add-network branch July 7, 2023 04:48

github-actions bot mentioned this pull request Jul 7, 2023

ci(changesets): versioning packages v0.11.0 #788

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: create addNetwork request method on sdk #793

feat: create addNetwork request method on sdk #793

eswarasai commented Jun 21, 2023 •

edited

Loading

github-actions bot commented Jun 22, 2023 •

edited

Loading

This comment was marked as resolved.

LuizAsFight left a comment

luizstacio left a comment

luizstacio Jul 3, 2023

luizstacio Jul 3, 2023

eswarasai Jul 4, 2023

luizstacio Jul 4, 2023

LuizAsFight Jul 4, 2023

luizstacio Jul 5, 2023

LuizAsFight Jul 6, 2023

LuizAsFight Jul 4, 2023

LuizAsFight left a comment

feat: create addNetwork request method on sdk #793

feat: create addNetwork request method on sdk #793

Conversation

eswarasai commented Jun 21, 2023 • edited Loading

Description

TODO

github-actions bot commented Jun 22, 2023 • edited Loading

Coverage report for ./packages/app

Test suite run success

This comment was marked as resolved.

LuizAsFight left a comment

Choose a reason for hiding this comment

luizstacio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuizAsFight left a comment

Choose a reason for hiding this comment

eswarasai commented Jun 21, 2023 •

edited

Loading

github-actions bot commented Jun 22, 2023 •

edited

Loading

Coverage report for `./packages/app`