doc: add fuelup http proxy setting document #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
reviewed
Apr 3, 2024
docs/src/basics.md
Outdated
Comment on lines
40
to
41
| To configure `fuelup` to use your proxy setting you can change `http_proxy` environment value. The value format is in [libcurl format](https://everything.curl.dev/libcurl/proxies#proxy-types) as in `[protocol://]host[:port]`. | ||
|
|
||
| ***Warning: don't leave `http_proxy` environment with empty string or other invalid format*** |
There was a problem hiding this comment.
We can add other options here as well since they are added with #592
There was a problem hiding this comment.
@kayagokalp Suggestion changes addressed~ Thanks for your review
kayagokalp
force-pushed
the
doc/http-proxy
branch
from
7063f9b to
984583a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I first run
fuelup toolchain install latest, I failed because of network errors, and didn't find the instruction to set an http proxy to solve this problem. We should add this part IMO 😀