-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forc-submit
to components.toml (sway #3875)
#689
Conversation
Weird... Haven't dived in to find the reason behind this yet, but the tests are failing because Sway release binaries [1] contain [1] https://github.com/FuelLabs/sway/releases/ |
With sway-nightly-binaries missing forc-submit is now fixed, I've run the build job to produce assets. I'll update the Then once tomorrow rolls over, all date hacks to |
978dfa0
to
08adfca
Compare
Wondering if we need to add the
|
@zees-dev Good catch. The second two, yes. But the first one, although I'm not actually sure where the line is to classify something to go into (it actually doesn't make any difference AFAICS in the code). |
tests/show.rs
Outdated
@@ -36,6 +36,7 @@ fn fuelup_show_latest() -> Result<()> { | |||
- forc-client | |||
- forc-deploy : 0.1.0 | |||
- forc-run : 0.1.0 | |||
- forc-submit : not found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these show 0.1.0 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! Oh wow, ok I see where I went wrong... I assumed that file didn't exist because it was pulling down an old version of from githubusercontent.com where forc-submit
doesn't exist, but they're actually coming from mocked files defined by ALL_BINS
. I'll fix that, thanks!
08adfca
to
1efdbb0
Compare
Thanks @sdankel, much better! |
Sway's FuelLabs/sway#3885 added a new executable to submit transactions to the network, but it was missed in the
fuelup
repo.