-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preliminary ci.yml #9
Conversation
Added clippy and fmt for now as checks but these will fail until #8 is merged (no Cargo.toml yet). |
Maybe target this PR into the other one rather than the master branch, so that we know the initial PR to master will pass CI. |
… binggh/introduce-ci
Hmm, now testing this on the test repo and the cross images are running into build errors which seem to stem from OpenSSL. Seems to be a long-standing issue and point of discussion over at cross: cross-rs/cross#229 Workaround seems to be to use a custom image and install the necessary packages(?) Trying this now. cc: @Voxelot, if you have suggestions from doing this in |
Ah interesting, it may be worth investigating a way to eliminate the dependency on OpenSSL given most libraries support webpki/rustls these days. I did have to do custom docker images for fuel-core but it was painful. |
Ah, okay 👍 Seems possible to build with |
Turns out
Builds seem to be working fine in the test repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, pending @Voxelot's fix - good spot
should be g2g, but let's see a test release fully work before merging |
Is there supposed to be some way to verify the developer(s) of the releases? Couldn't run the x86_64 mac binary myself at first, then tried a bit later and it worked somehow |
We'll need to get an apple developer certificate enabled in CI to resolve that. For now we'll need to find some kind of workaround to help users requests the permissions they need to run the binary on mac. cc @adlerjohn https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development |
If it's not needed for this PR, can you file an issue and assign it to me to follow-up on adding the cert? |
Things/checks to add: