-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
@adlerjohn Are there any blockers for this, or can we wrap it up and merge soonish? |
We have to wait for v0.7.0 of forc, which can be cut after the above PR is merged. |
Ah, I see, I took "now that FuelLabs/sway#815 is in." to mean 815 was done. |
@adlerjohn can we move ahead on this with the release of Forc v0.7.0 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should ensure this is tested before merging.
Can I push some tests to your branch here @adlerjohn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a tiny bit strange that is_none()
and is_err()
are matching against Some
and Ok
and returning false, instead of matching None
and Err
, but this works.
It isn't possible to instantiate a |
These tests still need to be implemented: sway-lib-std/tests/test_projects/result/src/main.sw Lines 11 to 25 in 3be26db
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So Emily's recent changes fixed the problems with instantiation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Reverts #63, now that FuelLabs/sway#815 is in.