Fixes blanket trait conflicts with impl trait for struct. (#5247)

## Description

When the same trait was implemented for a blanket implementation and for
a struct a conflict occurred.

With this commit, we use `UnifyCheck::non_generic_constraint_subset`
instead of `UnifyCheck::constraint_subset` this no longer unifies the
generic type from the blanket impl with the struct impl and the conflict
no longer occurs.

Closes #5244

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Co-authored-by: IGI-111 <igi-111@protonmail.com>

sway-core/src/semantic_analysis/namespace/trait_map.rs

@@ -235,7 +235,7 @@ impl TraitMap {
                     },
                 );
 
-                let unify_checker = UnifyCheck::constraint_subset(engines);
+                let unify_checker = UnifyCheck::non_generic_constraint_subset(engines);
                 let types_are_subset = unify_checker.check(type_id, *map_type_id);
                 let traits_are_subset = unify_checker.check(trait_type_id, map_trait_type_id);
 

test/src/e2e_vm_tests/test_programs/should_pass/language/blanket_trait/Forc.lock

@@ -0,0 +1,8 @@
+[[package]]
+name = "blanket_trait"
+source = "member"
+dependencies = ["core"]
+
+[[package]]
+name = "core"
+source = "path+from-root-764E7430BADFBDF1"

test/src/e2e_vm_tests/test_programs/should_pass/language/blanket_trait/Forc.toml

@@ -0,0 +1,8 @@
+[project]
+authors = ["Fuel Labs <contact@fuel.sh>"]
+license = "Apache-2.0"
+name = "blanket_trait"
+entry = "main.sw"
+
+[dependencies]
+core = { path = "../../../../../../../sway-lib-core" }

test/src/e2e_vm_tests/test_programs/should_pass/language/blanket_trait/json_abi_oracle.json

@@ -0,0 +1,25 @@
+{
+  "configurables": [],
+  "functions": [
+    {
+      "attributes": null,
+      "inputs": [],
+      "name": "main",
+      "output": {
+        "name": "",
+        "type": 0,
+        "typeArguments": null
+      }
+    }
+  ],
+  "loggedTypes": [],
+  "messagesTypes": [],
+  "types": [
+    {
+      "components": null,
+      "type": "bool",
+      "typeId": 0,
+      "typeParameters": null
+    }
+  ]
+}

test/src/e2e_vm_tests/test_programs/should_pass/language/blanket_trait/src/main.sw

@@ -0,0 +1,29 @@
+script;
+
+trait MyFrom<T> {
+    fn from(t: T) -> Self;
+}
+
+impl<T> MyFrom<T> for T {
+    fn from(t: T) -> T {
+        t
+    }
+}
+
+
+struct A {}
+
+struct B {}
+
+impl MyFrom<A> for B {
+    fn from(_t: A) -> B {
+        B {}
+    }
+}
+
+pub fn main() -> bool {
+    let a = A {};
+    let _b: B = B::from(a);
+
+    true
+}

test/src/e2e_vm_tests/test_programs/should_pass/language/blanket_trait/test.toml

@@ -0,0 +1,4 @@
+category = "run"
+expected_result = { action = "return", value = 1 }
+validate_abi = true
+expected_warnings = 1