Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc's test harness checks non-contracts for json abi #1117

Closed
eureka-cpu opened this issue Mar 31, 2022 · 0 comments · Fixed by #1105
Closed

forc's test harness checks non-contracts for json abi #1117

eureka-cpu opened this issue Mar 31, 2022 · 0 comments · Fixed by #1105
Assignees
@eureka-cpu
Labels
bug Something isn't working forc testing General testing

Comments

@eureka-cpu
Copy link
Contributor

eureka-cpu commented Mar 31, 2022 •
edited
Loading

number_of_tests_run in e2e_vm_tests::mod currently tests all should_pass test programs for json abi, including non-contracts.
@eureka-cpu eureka-cpu added bug Something isn't working forc testing General testing labels Mar 31, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Mar 31, 2022
@eureka-cpu eureka-cpu mentioned this issue Mar 31, 2022
Merged
@eureka-cpu eureka-cpu self-assigned this Mar 31, 2022
Repository owner moved this from Todo to Done in Fuel Network Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eureka-cpu eureka-cpu

Labels
bug Something isn't working forc testing General testing
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added check to forc_abi to fail on non-contracts FuelLabs/sway
1 participant
@eureka-cpu