Added check to forc_abi to fail on non-contracts

[eureka-cpu]

Closes #526 -- Initially reused the logic found in forc_deploy & forc_run to throw an error instead of an empty abi [] if the wrong program type was found.

Closes #1106 -- Replaced the CliError struct with anyhow::Error.

Closes #1117 -- Separated the tests in vec positive_project_names in e2e_vm_tests::mod into ...no_abi, ...with_abi, removed the json.oracle files and updated the surrounding functions to handle the aforementioned changes.

I've also converted the reused logic in forc_abi_json, forc_deploy & forc_run into a single function called check_program_type. To avoid circular dependency, I've moved it and its associated functions out of utils::cli_error and into forc_pkg::pkg since we decided to implement program_type as a method on manifest::Manifest. This helps by removing duplicate code which is being tracked here: #1107 .

[eureka-cpu]

@adlerjohn & @mitchmindtree getting this error on my machine even though CI passed:

Deploying should_pass/test_contracts/basic_storage
  Compiled library "core".
  Compiled library "std".
  Compiled library "basic_storage_abi".
  Compiled contract "basic_storage".
  Bytecode size is 108 bytes.
Contract id: 0xfa4d1b8c5dcbdd3a4ea073d162cb2313e89a03da03870a5561c12ffe10bca189
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: An error occured while creating a new object: Connection refused (os error 61)', test/src/e2e_vm_tests/harness.rs:31:10

[mohammadfawaz]

@adlerjohn & @mitchmindtree getting this error on my machine even though CI passed:

Deploying should_pass/test_contracts/basic_storage

  Compiled library "core".

  Compiled library "std".

  Compiled library "basic_storage_abi".

  Compiled contract "basic_storage".

  Bytecode size is 108 bytes.

Contract id: 0xfa4d1b8c5dcbdd3a4ea073d162cb2313e89a03da03870a5561c12ffe10bca189

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: An error occured while creating a new object: Connection refused (os error 61)', test/src/e2e_vm_tests/harness.rs:31:10

Do you have fuel-core running? If so, try to clean up ~/.forc and ~./fuel and then relaunch it.

[eureka-cpu]

Should you remove the JSON ABI oracle files for scripts in the test suite?

accidentally closed while trying to quote reply 🤦🏻 yes, I'll remove those rn thank you!

[mitchmindtree]

Getting closer!

[sezna]

approving to dismiss my requested changes but deferring to @mitchmindtree

[mitchmindtree]

Epic work @eureka-cpu, I think this is good to go!