Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the evm standard library test #2228

Open
mohammadfawaz opened this issue Jul 5, 2022 · 2 comments
Open

Expand the evm standard library test #2228

mohammadfawaz opened this issue Jul 5, 2022 · 2 comments
Labels
EVM Blockers for EVM support good first issue Good for newcomers lib: std Standard library testing General testing

Comments

@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented Jul 5, 2022

#2227 adds a basic evm test that should be expanded to test the rest of the evm library.

@simonr0204
Copy link
Contributor

simonr0204 commented Jul 6, 2022

Note that testing for ecrecover of and EVM address (the only functionality on top of the type currently) is here:

https://github.com/FuelLabs/sway/blob/master/test/src/e2e_vm_tests/test_programs/should_pass/stdlib/evm_ecr/src/main.sw

@mohammadfawaz
Copy link
Contributor Author

Nice! Actually that's a good point. We don't really need a contract to test that library right? So maybe the test I added is not really needed and the logic there can just be moved into a simpler test under should_pass/stdlib/.

@sezna sezna added the lib: std Standard library label Dec 18, 2022
@anton-trunov anton-trunov added the EVM Blockers for EVM support label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EVM Blockers for EVM support good first issue Good for newcomers lib: std Standard library testing General testing
Projects
Status: Todo
Development

No branches or pull requests

4 participants