Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix from in evm_address to make a mut local copy of the bits argument before calling mcli #2227

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fix from in evm_address to make a mut local copy of the bits argument before calling mcli #2227

merged 4 commits into from
Jul 5, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Jul 5, 2022 •
edited
Loading

Closes #2217

The test I added is not meant to be comprehensive for the evm library. Created a separate issue for that: #2228

@mohammadfawaz mohammadfawaz added bug Something isn't working lib: std Standard library P: critical Should be looked at before anything else labels Jul 5, 2022
@mohammadfawaz mohammadfawaz changed the title Fixing from in evm_address to make a mut local copy of the bits argument before calling mcli Fix from in evm_address to make a mut local copy of the bits argument before calling mcli Jul 5, 2022
@mohammadfawaz mohammadfawaz self-assigned this Jul 5, 2022
@mohammadfawaz mohammadfawaz mentioned this pull request Jul 5, 2022
Open
@mohammadfawaz mohammadfawaz marked this pull request as ready for review July 5, 2022 15:17
@mohammadfawaz mohammadfawaz requested a review from otrho as a code owner July 5, 2022 15:17
@mohammadfawaz mohammadfawaz requested review from Braqzen, nfurfaro and a team July 5, 2022 15:17
@mohammadfawaz mohammadfawaz merged commit e705caa into master Jul 5, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/2217 branch July 5, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen approved these changes

@nfurfaro nfurfaro nfurfaro approved these changes

@otrho otrho Awaiting requested review from otrho

Assignees

@mohammadfawaz mohammadfawaz

Labels
bug Something isn't working lib: std Standard library P: critical Should be looked at before anything else
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EvmAddress::from leads to memory overflow error
3 participants
@mohammadfawaz @nfurfaro @Braqzen