-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the sway-core/src/asm_generation
directory.
#2505
Comments
I took a birds eye view of what's in
|
This has changed a bit with #2843 but is still desperately needed. |
Here are some personal notes I took down at some point which might as well go here. They apply to #2906 too.
|
When switching from AST -> ASM to AST -> IR -> ASM all the new IR -> ASM code went in
from_ir.rs
to keep it simple and contained.But the old AST -> ASM code has been removed now and
from_ir.rs
is ~2500 lines and should be broken up and refactored. All the tests called from there and hosted insway-core/tests/ir_to_asm
still need to be moved over tosway/test/src/ir_generation
or somewhere similar, and switched to useFileCheck
.Treating this as a bit of a parent issue, here's some sub-issues:
asm_builder
up further.The text was updated successfully, but these errors were encountered: