Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP shows diagnostics for libraries in the wrong file #5027

Closed
sdankel opened this issue Aug 24, 2023 · 0 comments · Fixed by #5030
Closed

LSP shows diagnostics for libraries in the wrong file #5027

sdankel opened this issue Aug 24, 2023 · 0 comments · Fixed by #5030
Assignees
@sdankel
Labels
language server LSP server

Comments

@sdankel
Copy link
Member

sdankel commented Aug 24, 2023

The diagnostics on this file are very messed up. It seems to be returning the diagnostics from the library files for the main.sw file.

image

This is likely a bug on the LSP side.
@sdankel sdankel self-assigned this Aug 24, 2023
@sdankel sdankel added the language server LSP server label Aug 24, 2023
This was referenced Aug 24, 2023
Merged
Merged
JoshuaBatty added a commit that referenced this issue Aug 25, 2023
@sdankel @JoshuaBatty
Fix diagnostics in multi file projects (#5030)
bca210e 
## Description

Closes #5027

Now instead of caching the `Diagnostics` object, we cache a mapping of
file path -> `Diagnostics`

When we publish diagnostics, we only publishing the diagnostics for the
given URI, not for the entire project. I added a test where there are no
diagnostics in the main.sw file, but a bunch of diagnostics in the other
files in the project.

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdankel sdankel

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix diagnostics in multi file projects FuelLabs/sway
1 participant
@sdankel