Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of numeric security fix #6470

Closed
IGI-111 opened this issue Aug 27, 2024 · 0 comments · Fixed by #6471
Closed

Improve performance of numeric security fix #6470

IGI-111 opened this issue Aug 27, 2024 · 0 comments · Fixed by #6471
Assignees
@esdrubal
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request performance Everything related to performance, speed wise or memory wise.

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented Aug 27, 2024

The security fix implemented in #6461 results in a 25% performance drop, we need to improve on this using lexical scopes or other techniques.
@IGI-111 IGI-111 added enhancement New feature or request compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen performance Everything related to performance, speed wise or memory wise. labels Aug 27, 2024
esdrubal added a commit that referenced this issue Aug 27, 2024
@esdrubal
Improves TraitMap cloning performance.
9ed2785 
By using im::Vector inside TypeMap we avoid cloning everything when
cloning namespaces.

Fixes #6470.
@esdrubal esdrubal mentioned this issue Aug 27, 2024
Merged
8 tasks
@tritao tritao closed this as completed in 4fc554c Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esdrubal esdrubal

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request performance Everything related to performance, speed wise or memory wise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improves TraitMap performance. FuelLabs/sway
2 participants
@esdrubal @IGI-111