Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Cmp library #6597

Open
bitzoic opened this issue Sep 30, 2024 · 1 comment
Open

Introduce Cmp library #6597

bitzoic opened this issue Sep 30, 2024 · 1 comment
Labels
lib: std Standard library

Comments

@bitzoic
Copy link
Member

bitzoic commented Sep 30, 2024

A number of external projects have implemented their own min() and max() Cmp functions. These should be included in the std-lib for the u64, u8, u16, u32, U128 and u256 types.
@bitzoic bitzoic added the lib: std Standard library label Sep 30, 2024
@EdwardJES EdwardJES mentioned this issue Oct 15, 2024
Merged
8 tasks
@SwayStar123
Copy link
Member

Duplicate of #2351 and #6169

IGI-111 pushed a commit that referenced this issue Oct 23, 2024
@EdwardJES @K1-R1
feat: add TotalOrd library to core::ops for uint types (#6635)
40e2b30 
## Description
This PR addresses #6597. 

A `cmp` trait has been added that exposes:
- `min(self, Self) -> Self`
- `max(self, Self) -> Self`

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SwayStar123 @bitzoic