Add support for package field under dependencies. If unspecified, require that dependency name matches package name.
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
previously approved these changes
Mar 23, 2022
This allows for the dependency name to differ from the dependency's package name. Closes #977.
It is no longer valid for packages to contain a manifest with a name that does not match the name of the pinned package within the lock file. As a result, the lock files of these tests have been invalidated and regenerated.
mitchmindtree
dismissed stale reviews from JoshuaBatty and adlerjohn
via
3278751
mitchmindtree
force-pushed
the
mitchmindtree/forc-package-names
branch
from
225c89a to
3278751
Compare
|
Okydoke, fixed the test conflicts, should be good to go 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #977 - see that issue for motivation. Unblocks #978.
A new
should_pass/forc/dependency_package_fieldtest has been added that tests the functionality.All tests that depend on
stdand are pinned to asway-lib-stdcommit older than FuelLabs/sway-lib-std@385c457 have been updated to the latest commit.