Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical not formatting fix #1026

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Logical not formatting fix #1026

merged 4 commits into from
Mar 25, 2022

Conversation

eightfilms
Copy link
Contributor

@eightfilms eightfilms commented Mar 25, 2022 •
edited
Loading

closes #997

The ! operator was handled by appending with whitespace, which seemed to be the issue.

  • Extracted it into its own handle_logical_not_case
  • Added a basic test to test various scenarios

@eightfilms eightfilms marked this pull request as draft March 25, 2022 17:31
@adlerjohn adlerjohn linked an issue Mar 25, 2022 that may be closed by this pull request
Formatter adds extra space before ! for ifs #997
Closed
@adlerjohn
Copy link
Contributor

Thank you for the contribution @binggh! Is there still outstanding work for this PR?

@eightfilms
Copy link
Contributor Author

Thank you for the contribution @binggh! Is there still outstanding work for this PR?

Nope, I'll convert it to be ready for review.

@eightfilms eightfilms marked this pull request as ready for review March 25, 2022 17:55
@eureka-cpu
Copy link
Contributor

Lgtm nice work

@adlerjohn adlerjohn merged commit d07fdeb into FuelLabs:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu approved these changes

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

@mitchmindtree mitchmindtree Awaiting requested review from mitchmindtree

Assignees
No one assigned
Labels
formatter
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter adds extra space before ! for ifs
3 participants
@eightfilms @adlerjohn @eureka-cpu