Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for node dependency order for enum instantiations. #1036

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Fix for node dependency order for enum instantiations. #1036

merged 1 commit into from
Mar 27, 2022

Conversation

otrho
Copy link
Contributor

@otrho otrho commented Mar 27, 2022

Closes #1035.

@otrho otrho added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Mar 27, 2022
@otrho otrho self-assigned this Mar 27, 2022
mohammadfawaz
mohammadfawaz approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otrho otrho merged commit 546df70 into master Mar 27, 2022
@otrho otrho deleted the otrho/1035-enum-init-from-fn branch March 27, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@sezna sezna Awaiting requested review from sezna

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

Assignees

@otrho otrho

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency order of declarations is broken for enums.
3 participants
@otrho @adlerjohn @mohammadfawaz