Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fuel-core and add missing instructions. #1037

Merged
merged 4 commits into from
Mar 27, 2022
Merged

Bump fuel-core and add missing instructions. #1037

merged 4 commits into from
Mar 27, 2022

Conversation

adlerjohn
Copy link
Contributor

No description provided.

@adlerjohn adlerjohn added compiler General compiler. Should eventually become more specific as the issue is triaged dependencies breaking May cause existing user code to break. Requires a minor or major release. labels Mar 27, 2022
@adlerjohn adlerjohn self-assigned this Mar 27, 2022
@adlerjohn adlerjohn marked this pull request as ready for review March 27, 2022 17:35
@adlerjohn adlerjohn linked an issue Mar 27, 2022 that may be closed by this pull request
Use the MOVI opcode in codegen where possible #1033
Open
@adlerjohn adlerjohn marked this pull request as draft March 27, 2022 18:00
@adlerjohn
Copy link
Contributor Author

Need to actually codegen

@mohammadfawaz
Copy link
Contributor

Nice. We should really figure out a way to make all of these data driven somehow so that new opcodes just work in asm blocks.

@adlerjohn adlerjohn marked this pull request as ready for review March 27, 2022 18:22
@adlerjohn adlerjohn mentioned this pull request Mar 27, 2022
Merged
mohammadfawaz
mohammadfawaz approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adlerjohn adlerjohn merged commit 5840399 into master Mar 27, 2022
@adlerjohn adlerjohn deleted the adlerjohn/add-missing-instructions branch March 27, 2022 20:47
@adlerjohn adlerjohn mentioned this pull request Mar 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@sezna sezna Awaiting requested review from sezna

@otrho otrho Awaiting requested review from otrho

Assignees

@adlerjohn adlerjohn

Labels
breaking May cause existing user code to break. Requires a minor or major release. compiler General compiler. Should eventually become more specific as the issue is triaged dependencies
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the MOVI opcode in codegen where possible
2 participants
@adlerjohn @mohammadfawaz