New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Struct field type checking fix; Bad error message fix #105

Merged

sezna merged 0 commits into many_bugfixes_2 from master

Jul 5, 2021

Contributor

sezna commented Jul 3, 2021 •

edited

Loading

Draft until #94 goes in, as this is based on that. When that goes in, I'll clean up the diff here and mark it as ready.

As our team is growing, I'm going to be submitting much more granular PRs going forward, so reviewing is easier.

This PR:

Fixes a bug in the type checker of struct subfield expressions
Prevents a bad error message when there is an error inside the function arguments during assembly generation. Previously, the error would result in the argument being reported as missing, when in reality it just was missing from the asm namespace.

sezna merged commit 8d18513 into many_bugfixes_2

sezna force-pushed the many_bugfixes_2 branch from ccdc126 to d35ec7c Compare

July 5, 2021 05:38

adlerjohn added the compiler label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels