Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated errors and warnings. #1112

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Remove duplicated errors and warnings. #1112

merged 1 commit into from
Apr 1, 2022

Conversation

emilyaherbert
Copy link
Contributor

@emilyaherbert emilyaherbert added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Mar 30, 2022
@emilyaherbert emilyaherbert self-assigned this Mar 30, 2022
@emilyaherbert emilyaherbert marked this pull request as ready for review March 30, 2022 08:13
otrho
otrho reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they getting duplicated if the check!() is returning anyway? They're duplicated somewhere else?

mohammadfawaz
mohammadfawaz reviewed Mar 30, 2022
View reviewed changes
sway-core/src/lib.rs
let parse_tree = match parse_tree_result {
Some(parse_tree) => parse_tree,
None => {
errors = dedup_unsorted(errors);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

mohammadfawaz
mohammadfawaz approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sezna sezna merged commit 5bb1bc3 into master Apr 1, 2022
@sezna sezna deleted the emilyaherbert-1111/duplicate-warnings-and-errors branch April 1, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho left review comments

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@sezna sezna sezna approved these changes

@canndrew canndrew Awaiting requested review from canndrew

Assignees

@emilyaherbert emilyaherbert

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Fuel Network
Archived in project
Milestone
No milestone
4 participants
@emilyaherbert @otrho @sezna @mohammadfawaz